| Conditions | 2 |
| Total Lines | 147 |
| Code Lines | 120 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | import { StaticQuery, graphql } from "gatsby"; |
||
| 102 | renderPlayerStatsFull = (player) => { |
||
| 103 | if (this.state.loading === false && this.state.data) { |
||
| 104 | const { playerStatistics = [] } = this.state.data; |
||
| 105 | |||
| 106 | return ( |
||
| 107 | <Card |
||
| 108 | title="Statistieken" |
||
| 109 | className={`player-detail__stats`} |
||
| 110 | hasTable={true} |
||
| 111 | > |
||
| 112 | <table className={`player-detail__stats__table`}> |
||
| 113 | <thead> |
||
| 114 | <tr> |
||
| 115 | <th |
||
| 116 | className={`player-detail__column player-detail__column--string`} |
||
| 117 | > |
||
| 118 | Team |
||
| 119 | </th> |
||
| 120 | <th |
||
| 121 | className={`player-detail__column player-detail__column--number show-for-medium`} |
||
| 122 | > |
||
| 123 | <span title="Wedstrijden gespeeld">P</span> |
||
| 124 | </th> |
||
| 125 | <th |
||
| 126 | className={`player-detail__column player-detail__column--number`} |
||
| 127 | > |
||
| 128 | <span title="Wedstrijden gewonnen">W</span> |
||
| 129 | </th> |
||
| 130 | <th |
||
| 131 | className={`player-detail__column player-detail__column--number`} |
||
| 132 | > |
||
| 133 | <span title="Wedstrijden gelijkgespeeld">D</span> |
||
| 134 | </th> |
||
| 135 | <th |
||
| 136 | className={`player-detail__column player-detail__column--number`} |
||
| 137 | > |
||
| 138 | <span title="Wedstrijden verloren">L</span> |
||
| 139 | </th> |
||
| 140 | <th |
||
| 141 | className={`player-detail__column player-detail__column--number`} |
||
| 142 | > |
||
| 143 | <img |
||
| 144 | src={iconCardYellow} |
||
| 145 | title="Gele kaart" |
||
| 146 | alt="Gele kaart" |
||
| 147 | className="player-detail__stats--header_icon" |
||
| 148 | /> |
||
| 149 | </th> |
||
| 150 | <th |
||
| 151 | className={`player-detail__column player-detail__column--number`} |
||
| 152 | > |
||
| 153 | <img |
||
| 154 | src={iconCardRed} |
||
| 155 | title="Rode kaart" |
||
| 156 | alt="Rode kaart" |
||
| 157 | className="player-detail__stats--header_icon" |
||
| 158 | /> |
||
| 159 | </th> |
||
| 160 | <th |
||
| 161 | className={`player-detail__column player-detail__column--number`} |
||
| 162 | > |
||
| 163 | <img |
||
| 164 | src={iconGoal} |
||
| 165 | title="Doelpunt(en) gescoord" |
||
| 166 | alt="Doelpunt(en) gescoord" |
||
| 167 | className="player-detail__stats--header_icon" |
||
| 168 | /> |
||
| 169 | </th> |
||
| 170 | <th |
||
| 171 | className={`player-detail__column player-detail__column--number show-for-medium`} |
||
| 172 | > |
||
| 173 | <img |
||
| 174 | src={iconCleansheet} |
||
| 175 | title="Cleansheets" |
||
| 176 | alt="Cleansheets" |
||
| 177 | className="player-detail__stats--header_icon" |
||
| 178 | /> |
||
| 179 | </th> |
||
| 180 | <th |
||
| 181 | className={`player-detail__column player-detail__column--number`} |
||
| 182 | > |
||
| 183 | <span title="Minuten gespeeld"> |
||
| 184 | <Icon icon="fa-clock-o" /> |
||
| 185 | </span> |
||
| 186 | </th> |
||
| 187 | </tr> |
||
| 188 | </thead> |
||
| 189 | <tbody> |
||
| 190 | {playerStatistics.map(function (stats) { |
||
| 191 | return ( |
||
| 192 | <tr> |
||
| 193 | <td |
||
| 194 | className={`player-detail__column player-detail__column--string`} |
||
| 195 | > |
||
| 196 | {stats.team.replace(`Voetbal : `, ``)} |
||
| 197 | </td> |
||
| 198 | <td |
||
| 199 | className={`player-detail__column player-detail__column--number show-for-medium`} |
||
| 200 | > |
||
| 201 | {stats.gamesPlayed} |
||
| 202 | </td> |
||
| 203 | <td |
||
| 204 | className={`player-detail__column player-detail__column--number`} |
||
| 205 | > |
||
| 206 | {stats.gamesWon} |
||
| 207 | </td> |
||
| 208 | <td |
||
| 209 | className={`player-detail__column player-detail__column--number`} |
||
| 210 | > |
||
| 211 | {stats.gamesEqual} |
||
| 212 | </td> |
||
| 213 | <td |
||
| 214 | className={`player-detail__column player-detail__column--number`} |
||
| 215 | > |
||
| 216 | {stats.gamesLost} |
||
| 217 | </td> |
||
| 218 | <td |
||
| 219 | className={`player-detail__column player-detail__column--number`} |
||
| 220 | > |
||
| 221 | {stats.yellowCards} |
||
| 222 | </td> |
||
| 223 | <td |
||
| 224 | className={`player-detail__column player-detail__column--number`} |
||
| 225 | > |
||
| 226 | {stats.redCards} |
||
| 227 | </td> |
||
| 228 | <td |
||
| 229 | className={`player-detail__column player-detail__column--number`} |
||
| 230 | > |
||
| 231 | {stats.goals} |
||
| 232 | </td> |
||
| 233 | <td |
||
| 234 | className={`player-detail__column player-detail__column--number show-for-medium`} |
||
| 235 | > |
||
| 236 | {stats.cleanSheets} |
||
| 237 | </td> |
||
| 238 | <td |
||
| 239 | className={`player-detail__column player-detail__column--number`} |
||
| 240 | > |
||
| 241 | {stats.minutes}' |
||
| 242 | </td> |
||
| 243 | </tr> |
||
| 244 | ); |
||
| 245 | })} |
||
| 246 | </tbody> |
||
| 247 | </table> |
||
| 248 | </Card> |
||
| 249 | ); |
||
| 519 |